CompareBooleans

This actually made me laugh, thank you.

Usually comparison functions are supposed to return an integer and are usually useful for sorting. However this one returns a bool so it's both useless and terribly named.

The unnecessary and confusing functions are horrible, yes, but I'd still say that the fact that they're wrong is the "worst" part.

I don't like this thread anymore :(

that... actually works...

I quit based on idiotic metrics

Which is all the easier to do when you start off with a higher number...

I love deleting code, including my own, more than writing code. That's a killer metric imo.

My coworker made an array of book to express a status. This is no doing of an intern but a much eviler force at play.

I was debating on bitwise operations, but decided on super basic if statements which I think the compiler would optimize, happy to see the logical operation form too

I should have created a local variable to store the result variable and return after the if statements. I just couldn't help to make it look partially nice. My brain just doesn't think at this high caliber of LOC optimizations.

New optimized LOC version:

internal static bool AreBooleansEqual(bool orig, bool val)
{
    bool result;
    if(orig) 
    {
        if(val)
        {
            result = false;
        }
        else
        {
            result = true;
        }
    }
    else
    {
        if(val)
        {
            result = true;
        }
        else
        {
            result = false;
        }
    }
    return result;
}

My previous LOC: 12
New LOC version: 27

var CompareBooleans = new ComparatorFactory().BooleanComparator(new BooleanComparisonByEqualityPolicy());
if (CompareBooleans(a, b) == true) {
     System.Out.PrintLn("Sames!!!");
}

...

But now that I've written this, it's C#, so it's missing dependency injection.

You must have been working with the Redditors who told me that avoiding the use of JavaScript's eval() to parse JSON was a false sense of security.

It's dependent on is-odd which is dependent on is-number which has 88 million weekly downloads...

GitHub page of this program:

I created this in 2014, when I was learning how to program.

You're hired. Can your start on Monday?

You're right, this is just not oop AT ALL.

For the correct OOP solution, you would need consider whether this can be thought of as a kind of stateless leaf method, and therefore implement it as an abstract (singleton) factory, but on the other hand, if you're using a context object with the registry pattern, you should probably do this properly with IoC containers. Of course, if your object graph isn't too complex or entangled, you could always just do constructor injection but you risk manging your unit tests, so I would go cautiously if I were looking in that direction.

I know. I didn't say this was OOP, I said this was your brain when you OD on OOP. While we are not dealing with objects, I'd argue that the kind of approach that would lead one to needlessly overcompartmentalise code like this is the product of having a little too much OOP.

Still good advice, though.