Because it originally didn't account for time zones at all....it was very "everybody is in Virginia". The day was even wrong for many countries. When a training program shifted to include other countries it suddenly mattered. And it correlated to other data that did have times.
We use a version of Git Flow for branching (since everyone is talking about branching strategies here). But technically, you asked specifically about code review process. Every ticket is it's own branch against the development branch, and when complete is merged by PR into the development branch. We're a small team, so our current process is:
- Merges to the development branch require one approval
- Merges to the main branch for a release require two approvals
- If the changes are only code, any developer can review and approve
- If there are "significant" SQL changes a DBA approval is required.
- "significant" means a new entity in the DB, or...
- an inline/Dapper query with a join
As we grow we'll probably have to silo more and require specific people's approval for specific areas.
A lot of what we do is "cultural", like encouraging readability, avoiding hard-coded values, and fixing issues near the altered code even when not related to the original ticket. The key is to be constructive. The goal is better code, not competition. So far we have the right people for that to work.
Entirely plausible. My perspective is naturally limited to just what I know.
This only works out of you're not tracking future dates, but yeah, that's basically what we're doing. Server side is UTC, UI converts into user's zone for display and sends UTC back to the server.
I've been on military time since doing a lot military contracting.
Man, we just finally got away from supporting Internet Exploder.
I hate time zones, especially when I'm stupid
The primary application at my job was...not well written. Originally .NET Framework 3.5 with a strange collection of approaches to MVC. SQL Server for data. I claimed it look like something written by CS students fresh out of college on their first job. Turned out I was close...it was written by 3rd-year CS interns. We've fixed and improved a ton (including migrating to .NET 6 earlier this year).
One of the ongoing issues was the use of SMALLDATETIME and DATE fields for everything. We've been gradually migrating these to DATETIME2 or DATETIMEOFFSET (we don't have future dates) as UTC. Because 95% of our usage had been CST/EST, we've typically set the time component to 17 hours to get a reasonable noonish time in those zones when we don't have a better time of day.
Had another round of these today and thought it was going well. Finally got it running and everything was +1 day from where it should be. Spent an hour trying to figure out the issue.
Converting for display incorrectly? No. Serializer not doing what was expected? No. Configured time zone got messed up? No. Brought in our DBA to help me figure it out.
I had added 17 days twice.
Side note: I wish everybody was on UTC time and time zones would forever disappear into the ether.
TLDR; Migrated time wrong because I'm stupid.
Modding as we know it today really started with Civ (Civ II, to be precise). There were several sharing different mods back then. I had one of the most popular ones for a while, to the point where MicroProse asked to post a link on the official site. The mods were ZIP files with instructions, and nobody had come up with a name for them. I started referring to them as "modpacks", and that stuck. Eventually that was shortened to just "mods". True story!
(FYI you can see here where MicroProse put links to other websites. Mine was listed in 1997, where the wayback machine doesn't have entries.)
Same...I also never received an email, but tried to log in after a while and that worked.
Difference between comments icons?
I noticed on comments there are these two icons that seem link a permalink to the comment. They seem to both always point to the same URL. What's the difference supposed to be? I looked around but searching for "link" and/or "icon" brings up an awful lot.