is it normal i'm afraid to do a coworker PR, even though i am forced to by my teamlead?
is it normal i'm afraid to do a coworker PR, even though i am forced to by my teamlead?
Tldr: coworker lash out at me for doing his PRs, he always wants to call after I review his stuff so I can read the shit I wrote in the comments live. What can I do?
I’m a junior FE dev and there is a guy on my team, with more YOE then me, whose PRs are, most of the time, a mess.
He improved recently, after we had a big fight after three out of three PRs were broken - as in, full of errors, bugs and with missing/half backed features. Nonetheless, his PRs are a time sink:
- he doesn’t follow the design closely, which means I waste a lot of time pointing out obvious differences
- he is huge hack - his motto is “if it works, it’s good”; as you can imagine this means his code works by God’s grace, which makes me believe he is a part-time messiah (it works until it doesn’t anymore after all).
- Finally, the thing I hate the most, is that he always wants to call for us to fix his stuff together, which would be fine if it were hard but it’s not, we don’t do anything hard and our work is mostly mechanical. And if he is in a bad mood, which he is most of the time, he lash out at me telling me to merge his stuff and that he will fix it later
So well, a few days after our fight I did a small experiment: I merged every PR he sent me. It went down as well as you can imagine, to the point where the team lead asked me to fix the history and the mess he made (and I had to drop a lot of commits).
And well, I thought “here, he finally got it!”. Except he didn’t, his PRs are still a mess - albeit with slightly better testing [as in, now they are with a lot of warnings and differences with the design and hacks, but no breaking error most of the time!] - and he still wants to call me every time I did a review, which means I have to review the same fucking PR twice - if I’m lucky.
Do you work in a toxic environment, OP?
If this single dev is just toxic, leave comments pointing out the facts. Don't take phone calls without a third party. Elevate to team lead.
As a dept head, i stomp out this shit. Because I dont care if you're a godlike coder or not.
Of course, if you work in a toxic environment where even the leads are sensitive to feedback, then not sure what to do.
It really isn’t. I enjoy talking with him etc, it’s just that work wise it’s painful.
The company is a little mess though, not cause of power trips - we don’t have those - but the organisation is quite poor
Malicious compliance.
he doesn’t follow the design closely
Ignoring the word closely here.
Reject the pr for not following the design. But point out where and what isn't being followed.
if he starts getting abusive ( yelling, profanity, insults, lashing out as you say) end the call and make a transcript for your manager of the call.