What's an inexpensive or low-quality item that you ended up loving and keeping for years?
I bought a lift-top coffee table from a big box store almost a decade ago. It's entirely particle board and has seen better days cosmetically, but it's probably my single favorite piece of furniture. It's immensely practical for meals, using a laptop, or just bringing your remote/drink/whatever closer to your hand when laying down on the couch. I instinctively try to lift other people's coffee tables when I visit, and am mildly annoyed when it doesn't work...
This may not meet your "keeping for years" criterion but never invest in expensive non-stick pans. Don't go super cheap either, but something basic like T-Fal. Non-stick pans wear out over time ALWAYS. So there's no point buying premium ones.
Get something good enough that it's got a flat base and the coating isn't paper-thin, but beyond that save the big $$$ for cookware that doesn't have a non-stick coating. And when they eventually wear out you won't feel bad tossing them in the trash because that what you'll have to do anyway.
I picked up a pair of Oxo branded ones recently. They nest together and work great. It's been a couple months and no major signs of wear yet, so pretty happy with them and cleanup is a breeze. I still use my venerable stainless pan for bigger dishes though.
Ninja has a nice set of non stick pans that arent super expensive that I've been eyeing to replace my tfal pans. This is pretty much the same mindset I'm going with - replace every 5-7 years with another inexpensive set.